Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

Add NWB export pytests #50

Merged
merged 25 commits into from
Apr 29, 2022
Merged

Add NWB export pytests #50

merged 25 commits into from
Apr 29, 2022

Conversation

kabilar
Copy link
Collaborator

@kabilar kabilar commented Mar 21, 2022

@kabilar
Copy link
Collaborator Author

kabilar commented Mar 21, 2022

Hi @bendichter, I copied over your pytests from Slack and made some minor modifications. Please take a look and let me know if you see any issues. Thanks!

@CBroz1 CBroz1 mentioned this pull request Oct 14, 2022
Open
CBroz1
CBroz1 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run in docker, but the edits look good to me. Couple minor comments.

@kabilar kabilar mentioned this pull request Mar 23, 2022
Merged
@bendichter
Copy link

The tests look fine to me

@kabilar
Copy link
Collaborator Author

kabilar commented Apr 15, 2022

Update to README:

  • Add citation section.
  • Update links to point to elements.datajoint.org instead of the datajoint-elements GitHub repository.
  • Remove images of upstream Elements to shorten README.

@CBroz1 CBroz1 assigned kabilar and unassigned CBroz1 Apr 20, 2022
@ttngu207 ttngu207 merged commit 26a8bf6 into datajoint:main Apr 29, 2022
@kabilar kabilar mentioned this pull request Apr 29, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees

@kabilar kabilar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kabilar @bendichter @CBroz1 @ttngu207