Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

Workshop Docker image #22

Closed
wants to merge 6 commits into from
Closed

Conversation

drewyangdev
Copy link
Contributor

This is different from the present Dockerfile, so named it as Dockerfile.workshop

@drewyangdev drewyangdev marked this pull request as draft September 1, 2021 17:09
@drewyangdev drewyangdev marked this pull request as ready for review September 1, 2021 17:10
@drewyangdev drewyangdev closed this Sep 1, 2021
@drewyangdev drewyangdev reopened this Sep 1, 2021
@drewyangdev
Copy link
Contributor Author

@ttngu207

@kabilar kabilar self-assigned this Dec 22, 2021
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yambottle. A few thoughts listed below.

  • Should we move the file changes in .datajoint_config.json and Dockerfile.workshop to somewhere in the vathes GitHub organization since this is specific to our JupyterHub configuration? The files within workflow-array-ephys are meant for more general community use without our hosted resources.

  • Please remove tests/test_export.py as the NWB export function in element-array-ephys is not quite ready for release.

@kabilar kabilar changed the title Workshop docker image for the workflow-array-ephys Workshop Docker image Dec 22, 2021
@drewyangdev
Copy link
Contributor Author

Thanks @Yambottle. A few thoughts listed below.

  • Should we move the file changes in .datajoint_config.json and Dockerfile.workshop to somewhere in the vathes GitHub organization since this is specific to our JupyterHub configuration? The files within workflow-array-ephys are meant for more general community use without our hosted resources.
  • Please remove tests/test_export.py as the NWB export function in element-array-ephys is not quite ready for release.

This was a long-time-ago PR that I wasn't sure where to put this workshop dockerfile, I'll move it to vathes/dj-ops-tf since that repo is more devops general

@drewyangdev
Copy link
Contributor Author

@kabilar I'd recommend to abandon this PR, since everything is so outdated

@kabilar
Copy link
Collaborator

kabilar commented Dec 22, 2021

Thanks @Yambottle. That sounds like a good plan. I will close this pull request as many of the remaining changes are in #18.

@kabilar kabilar closed this Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants