-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Yambottle. A few thoughts listed below.
-
Should we move the file changes in
.datajoint_config.json
andDockerfile.workshop
to somewhere in thevathes
GitHub organization since this is specific to our JupyterHub configuration? The files withinworkflow-array-ephys
are meant for more general community use without our hosted resources. -
Please remove
tests/test_export.py
as the NWB export function inelement-array-ephys
is not quite ready for release.
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
This was a long-time-ago PR that I wasn't sure where to put this workshop dockerfile, I'll move it to vathes/dj-ops-tf since that repo is more devops general |
@kabilar I'd recommend to abandon this PR, since everything is so outdated |
Thanks @Yambottle. That sounds like a good plan. I will close this pull request as many of the remaining changes are in #18. |
This is different from the present
Dockerfile
, so named it asDockerfile.workshop