Skip to content

Conversation

@david-behar
Copy link
Collaborator

No description provided.

@david-behar david-behar requested a review from Marsobad July 25, 2022 12:54
Copy link
Contributor

@Marsobad Marsobad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

  • Bug reproduced on DSS 11
  • Fix tested on DSS 10 + 11
    • train in analysis
    • train + score in the flow
    • custom web app

Regarding integration tests, someone from my team is working on setting them up on a DSS 11 instance.

However, I am worried about customers who upgrade to v11 without updating the glm plugin. If they deployed a glm classification, their existing flows will break => they'll get the following error message in the deployed train recipe : [12:10:30] [INFO] [dku.utils] - Exception: Data must be 1-dimensional (same thing if they retrain from the original analysis)

The least we can do is to document this error in the change log and the plugin doc. We need to think about other solutions to prevent flows from breaking.

@david-behar david-behar merged commit 1683ac8 into main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants