Skip to content

fix(ci): enable publish on release #13506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

david-leifker
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
property "run-publish-images" is not defined in object type {ci-optimize: {conclusion: string; outcome: string; outputs: {actions-change: string; backend-change: string; backend-only: string; docker-change: string; elasticsearch-setup-change: string; frontend-change: string; frontend-only: string; ingestion-base-change: string; ingestion-change: string; ingestion-only: string; kafka-setup-change: string; mysql-setup-change: string; postgres-setup-change: string; smoke-test-change: string}}; docker-login: {conclusion: string; outcome: string; outputs: {string => string}}; pr-publish: {conclusion: string; outcome: string; outputs: {string => string}}; publish: {conclusion: string; outcome: string; outputs: {string => string}}; set-runner: {conclusion: string; outcome: string; outputs: {string => string}}; tag: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]

run_publish_images: ${{ steps.run-publish-images.outputs.run_publish_images}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:2:3: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:7:3: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:115: Double quote to prevent globbing and word splitting [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:117: Double quote to prevent globbing and word splitting [shellcheck]

Copy link
Collaborator

@esteban esteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@david-leifker david-leifker merged commit 1ac41e9 into master May 14, 2025
23 of 24 checks passed
@david-leifker david-leifker deleted the david-leifker-patch-1 branch May 14, 2025 01:31
esteban pushed a commit that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants