Skip to content

fix(sdk): use pluralized assertions #13481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anthonyburdi
Copy link
Contributor

Match the pluralization of other uses.

@anthonyburdi anthonyburdi self-assigned this May 9, 2025
@anthonyburdi anthonyburdi requested a review from jayacryl May 9, 2025 19:27
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
metadata-ingestion/src/datahub/sdk/main_client.py 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@anthonyburdi anthonyburdi requested a review from hsheth2 May 9, 2025 19:30
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 9, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 9, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 9, 2025
@anthonyburdi anthonyburdi merged commit f71ff77 into datahub-project:master May 9, 2025
57 of 59 checks passed
@anthonyburdi anthonyburdi deleted the ab--fix-assertion-client-pluralization branch May 9, 2025 20:31
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants