From 18557ed42a1fa369d0e02584fa0934b1c95c53aa Mon Sep 17 00:00:00 2001
From: zack3241 <zmjlawson@gmail.com>
Date: Thu, 10 Jun 2021 12:06:27 -0700
Subject: [PATCH] feat(k8s): Add imagePullSecrets to all K8's jobs (#2671)

---
 .../datahub-upgrade/datahub-cleanup-job-template.yml          | 4 ++++
 .../datahub/templates/datahub-upgrade/datahub-upgrade-job.yml | 4 ++++
 .../datahub/templates/elasticsearch-setup-job.yml             | 4 ++++
 datahub-kubernetes/datahub/templates/kafka-setup-job.yml      | 4 ++++
 datahub-kubernetes/datahub/templates/mysql-setup-job.yml      | 4 ++++
 5 files changed, 20 insertions(+)

diff --git a/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-cleanup-job-template.yml b/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-cleanup-job-template.yml
index b5423846b0c5f..298e374fd8d29 100644
--- a/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-cleanup-job-template.yml
+++ b/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-cleanup-job-template.yml
@@ -25,6 +25,10 @@ spec:
         {{- end }}
         {{- with .Values.datahubUpgrade.serviceAccount }}
           serviceAccountName: {{ . }}
+        {{- end }}
+        {{- with .Values.imagePullSecrets }}
+          imagePullSecrets:
+            {{- toYaml . | nindent 12 }}
         {{- end }}
           volumes:
           {{- with .Values.datahubUpgrade.extraVolumes }}
diff --git a/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-upgrade-job.yml b/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-upgrade-job.yml
index feaceb8546f38..6c904cab23e90 100644
--- a/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-upgrade-job.yml
+++ b/datahub-kubernetes/datahub/templates/datahub-upgrade/datahub-upgrade-job.yml
@@ -23,6 +23,10 @@ spec:
     {{- end }}
     {{- with .Values.datahubUpgrade.serviceAccount }}
       serviceAccountName: {{ . }}
+    {{- end }}
+    {{- with .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{- toYaml . | nindent 8 }}
     {{- end }}
       volumes:
       {{- with .Values.datahubUpgrade.extraVolumes }}
diff --git a/datahub-kubernetes/datahub/templates/elasticsearch-setup-job.yml b/datahub-kubernetes/datahub/templates/elasticsearch-setup-job.yml
index 8a2e4a7ca2f27..1aaed30ee7c1b 100644
--- a/datahub-kubernetes/datahub/templates/elasticsearch-setup-job.yml
+++ b/datahub-kubernetes/datahub/templates/elasticsearch-setup-job.yml
@@ -23,6 +23,10 @@ spec:
     {{- end }}
     {{- with .Values.elasticsearchSetupJob.serviceAccount }}
       serviceAccountName: {{ . }}
+    {{- end }}
+    {{- with .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{- toYaml . | nindent 8 }}
     {{- end }}
       volumes:
       {{- with .Values.elasticsearchSetupJob.extraVolumes }}
diff --git a/datahub-kubernetes/datahub/templates/kafka-setup-job.yml b/datahub-kubernetes/datahub/templates/kafka-setup-job.yml
index 54da08547b947..5776398e3670c 100644
--- a/datahub-kubernetes/datahub/templates/kafka-setup-job.yml
+++ b/datahub-kubernetes/datahub/templates/kafka-setup-job.yml
@@ -28,6 +28,10 @@ spec:
       securityContext:
         runAsUser: 1000
         fsGroup: 1000
+    {{- with .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{- toYaml . | nindent 8 }}
+    {{- end }}
       volumes:
         {{- with .Values.global.credentialsAndCertsSecrets }}
         - name: datahub-certs-dir
diff --git a/datahub-kubernetes/datahub/templates/mysql-setup-job.yml b/datahub-kubernetes/datahub/templates/mysql-setup-job.yml
index 97b8ac9ef655a..52a1e3b8fe931 100644
--- a/datahub-kubernetes/datahub/templates/mysql-setup-job.yml
+++ b/datahub-kubernetes/datahub/templates/mysql-setup-job.yml
@@ -23,6 +23,10 @@ spec:
     {{- end }}
     {{- with .Values.mysqlSetupJob.serviceAccount }}
       serviceAccountName: {{ . }}
+    {{- end }}
+    {{- with .Values.imagePullSecrets }}
+      imagePullSecrets:
+        {{- toYaml . | nindent 8 }}
     {{- end }}
       volumes:
       {{- with .Values.mysqlSetupJob.extraVolumes }}