This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Implement select_columns #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
approved these changes
Mar 11, 2022
jimexist
reviewed
Mar 11, 2022
| @@ -51,6 +51,12 @@ impl PyDataFrame { | |||
| self.df.schema().into() | |||
| } | |||
|
|
|||
| #[args(args = "*")] | |||
| fn select_columns(&self, args: Vec<&str>) -> PyResult<Self> { | |||
There was a problem hiding this comment.
maybe we can instead provide __getitem__ which is more pythonic
There was a problem hiding this comment.
good idea, i think we could have both 👍
There was a problem hiding this comment.
I have been looking at the python documentation for __getitem__ but it isn't clear to me how this would apply here for selecting multiple columns?
There was a problem hiding this comment.
I guess the idea is to index by list:
df[["a", "b"]]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.