Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Improve error reporting for PK type mismatch #851

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Improve error reporting for PK type mismatch #851

merged 1 commit into from
Jan 12, 2024

Conversation

vvkh
Copy link
Contributor

@vvkh vvkh commented Jan 12, 2024

  • Add error type DataDiffMismatchingKeyTypesError for diffs with PK columns of different types.
  • Make the error message more clear: show column names instead of internal types representation.

@vvkh vvkh requested review from nolar and dlawin January 12, 2024 13:10
@vvkh vvkh marked this pull request as ready for review January 12, 2024 13:10
@vvkh vvkh force-pushed the pk-mistmach-error-reporting branch from 2c81b02 to b71db7a Compare January 12, 2024 13:35
@vvkh vvkh force-pushed the pk-mistmach-error-reporting branch from b71db7a to a3410f0 Compare January 12, 2024 13:35
@vvkh vvkh merged commit 2cc7f93 into master Jan 12, 2024
@vvkh vvkh deleted the pk-mistmach-error-reporting branch January 12, 2024 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nolar nolar nolar approved these changes

@dlawin dlawin Awaiting requested review from dlawin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvkh @nolar