This repository was archived by the owner on May 17, 2024. It is now read-only.
Added colors to diff output #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw you can ignore whitespace in github too: https://github.com/datafold/data-diff/pull/34/files?diff=split&w=1 |
sirupsen
approved these changes
May 25, 2022
| @click.option("-v", "--verbose", is_flag=True, help="Print extra info") | ||
| @click.option("-i", "--interactive", is_flag=True, help="Confirm queries, implies --debug") | ||
| @click.option( | ||
| "-j", "--threads", default=None, help="Number of threads to use. 1 means no threading. Auto if not specified." |
There was a problem hiding this comment.
Isn't the default 1 thread? What does auto mean? I think it should be 1 so that the output is nice and expected in the default case. It's also far safer on a relational database where much more could really have an impact (especially with the current queries).
Sorry I know this is not strictly related here, but I must've missed this on the other PR. I thought I read for this when I reviewed the threading PR
There was a problem hiding this comment.
Let's discuss it on slack.
nolar
pushed a commit
that referenced
this pull request
Apr 6, 2023
snowflake: add support for key password
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.