Oracle connection doesn't have a port number

[skaosYan]

Hi,

Oracle connector connects to a default port 1521 only. Please add ability to specify port.

class Oracle(ThreadedDatabase):
dialect = Dialect()
CONNECT_URI_HELP = "oracle://:@/"
CONNECT_URI_PARAMS = ["database?"]

[alwyndsouza]

make changes in oracle.py file on line #163 #166 #167

/usr/local/lib/python3.9/site-packages/sqeleton/databases

161 class Oracle(ThreadedDatabase):
162 dialect = Dialect()
163 CONNECT_URI_HELP = "oracle://:@:/"
164 CONNECT_URI_PARAMS = ["database?"]
165
166 def init(self, *, host, database, port, thread_count, **kw):
167 self.kwargs = dict(dsn=f"{host}:{port}/{database}" if database else host, **kw)
168
169 self.default_schema = kw.get("user").upper()
170
171 super().init(thread_count=thread_count)
172

[github-actions]

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

[skaosYan]

Hey, can this issue be fixed??

[alwyndsouza]

Thanks for fixing the issue .
#548