Skip to content

Commit bcff62a

Browse files
committed
some fixes
1 parent 7558d11 commit bcff62a

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

backend/app/datasets/service.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,13 @@ def list_configs(dataset_name: str = None):
5050
configs = []
5151
for obj in objects:
5252
key: str = obj.get("key", "")
53-
config_name = key.removeprefix(prefix).removesuffix(".json")
53+
config_file_name = key.removeprefix(prefix).split("/")[-1]
54+
config_name = config_file_name.removesuffix(".json")
55+
dataset_name = key.removeprefix(prefix).removesuffix(config_file_name).removesuffix("/") or None
5456
configs.append(
5557
{
56-
"dataset_name": dataset_name,
5758
"config_name": config_name,
59+
"dataset_name": dataset_name,
5860
"storage_path": key,
5961
"size": obj.get("size"),
6062
"last_modified": obj.get("last_modified"),

backend/app/jobs/service.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@
1919
]
2020

2121

22-
def _get_name(model_name: str, pipeline: str):
22+
def _get_run_name(model_name: str, pipeline: str):
2323
name = model_name.split("/")[1].split("-")[0]
24-
name += pipeline
24+
name += f"-{pipeline}"
2525
return name.lower()
2626

2727

2828
def _get_run_cmd(inputs: JOB_INPUTS):
2929
# Job command
3030
cmd = "ovhai job run -o json"
31-
cmd += f" --name {inputs.name or _get_name(inputs.model_name, inputs.pipeline)}"
31+
cmd += f" --name {inputs.name or _get_run_name(inputs.model_name, inputs.pipeline)}"
3232

3333
# GPU
3434
if inputs.gpu:

frontend/src/pages/jobs/submit.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export default function JobsSubmit() {
4848
const { data: selectedConfig } = useGetDatasetConfig(inputs?.dataset_config, inputs?.dataset_name)
4949

5050
const navigate = useNavigate()
51-
const required = inputs.name && inputs.model_name && inputs.dataset_name && ((pushToHF && inputs?.hf_hub) || !pushToHF)
51+
const required = inputs.model_name && inputs.dataset_name && ((pushToHF && inputs?.hf_hub) || !pushToHF)
5252

5353
const resetInputs = () => {
5454
setPushToHF(false)
@@ -116,8 +116,8 @@ export default function JobsSubmit() {
116116
return () => Object.values(debouncedTimersRef).forEach((t) => t && clearTimeout(t))
117117
}, [])
118118

119-
console.log("input", inputs)
120-
console.log("errors", errors)
119+
// console.log("input", inputs)
120+
// console.log("errors", errors)
121121

122122
return (
123123
<Container className="fr-my-3w">

0 commit comments

Comments
 (0)