Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with multiple drivers #9

Closed
prochac opened this issue Jan 19, 2024 · 0 comments
Closed

Test with multiple drivers #9

prochac opened this issue Jan 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@prochac
Copy link
Contributor

prochac commented Jan 19, 2024

The integtest pkg uses github.com/jackc/pgx/v4/stdlib, while we actually use v5 in production.
The versions are mostly compatible, but may have some small nuances.

The tested versions should be:

  • github.com/lib/pq
  • github.com/jackc/pgx/v4/stdlib
  • github.com/jackc/pgx/v5/stdlib
  • ... next releases of pgx

Import pgx driver using driverName with version included
jackc/pgx#1480

Keep the usage of drivers inside integrtest pkg, this helps Go reduce dependencies. Go 1.21 (I think) does some smart "dependency-shaking"

@prochac prochac added enhancement New feature or request good first issue Good for newcomers labels Jan 19, 2024
@prochac prochac closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant