jupyter chap03, flow edits chap02-chap03 #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhodges
requested changes
Feb 21, 2022
There was a problem hiding this comment.
This looks great, thank you @quist00. I've suggested a few typo fixes/language polishes, and split up some long lines. Once those are addressed, I think this is good to go.
typo suggestion Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
wording suggestions Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
spelling Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
wording suggestion Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
tobyhodges
approved these changes
Feb 22, 2022
|
Excellent stuff, thank you very much @quist00 🙌 |
zkamvar
pushed a commit
that referenced
this pull request
Apr 25, 2023
jupyter chap03, flow edits chap02-chap03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts Chap03 to leverage Jupyter rather than command line scripts. Moved imports callout to Chap02 since that is now hands on and does includes. Modified text of Chap03 to make it recognize what they already did in chapter two and build on it rather than acting like all concepts were new. Added callout to explain why we don't just use skimage.io.imshow().