Fix access to remote Helm repostories #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Call ChartDownloader with a list of all available getters * Return error from downloadTo to get better feedback why something went wrong
|
Thank you! |
|
Hi, Access to remote Helm repositories is great. Notised an issues: Fix: #30 |
|
@aananthraj yeah, I also noticed this but it's not directly related to this PR. |
|
yes @elemental-lf , its no way related to this PR, but its a kind of cleanup around it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had the problem that helm-diff failed when I specified a remote Helm chart on the command line. Investigation showed that ChartDownloader failed because it knew nothing about the http and https schemes. This PR fixes this problem. I'm using Helm version 2.7.2.
something went wrong