Upload acceptance artifacts before commenting on a pull request (#191)

Author: nfx

acceptance/go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.5.1 // MIT
 	github.com/Azure/azure-sdk-for-go/sdk/keyvault/azsecrets v0.12.0 // MIT
 	github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.3.0 // MIT
-	github.com/databricks/databricks-sdk-go v0.33.0 // Apache 2.0
+	github.com/databricks/databricks-sdk-go v0.40.0 // Apache 2.0
 	github.com/databrickslabs/sandbox/go-libs v0.1.0 // Databricks License
 	github.com/nxadm/tail v1.4.11 // MIT
 	github.com/sethvargo/go-githubactions v1.2.0 // Apache 2.0

acceptance/main.go

@@ -77,17 +77,17 @@ func (a *acceptance) trigger(ctx context.Context) (*notify.Notification, error)
 	if err != nil {
 		return nil, fmt.Errorf("report: %w", err)
 	}
+	err = a.Upload(ctx, artifactDir)
+	if err != nil {
+		return nil, fmt.Errorf("upload artifact: %w", err)
+	}
 	// better be redacting twice, right?
 	summary := redact.ReplaceAll(report.StepSummary())
 	a.Action.AddStepSummary(summary)
 	err = a.AddOrUpdateComment(ctx, summary)
 	if err != nil {
 		return nil, fmt.Errorf("comment: %w", err)
 	}
-	err = a.Upload(ctx, artifactDir)
-	if err != nil {
-		return nil, fmt.Errorf("upload artifact: %w", err)
-	}
 	runUrl, err := a.RunURL(ctx)
 	if err != nil {
 		return nil, fmt.Errorf("run url: %w", err)

acceptance/shim.js

@@ -1,4 +1,4 @@
-const version = 'v0.2.1';
+const version = 'v0.2.2';
 const action = 'acceptance';
 
 const { createWriteStream, chmodSync } = require('fs');

go-libs/go.mod

@@ -4,7 +4,7 @@ go 1.21.0
 
 require (
 	github.com/briandowns/spinner v1.23.0
-	github.com/databricks/databricks-sdk-go v0.41.0
+	github.com/databricks/databricks-sdk-go v0.40.0
 	github.com/fatih/color v1.16.0
 	github.com/google/go-querystring v1.1.0
 	github.com/nwidger/jsoncolor v0.3.2

go-libs/go.sum

@@ -10,8 +10,8 @@ github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cpuguy83/go-md2man/v2 v2.0.3/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
-github.com/databricks/databricks-sdk-go v0.41.0 h1:OyhYY+Q6+gqkWeXmpGEiacoU2RStTeWPF0x4vmqbQdc=
-github.com/databricks/databricks-sdk-go v0.41.0/go.mod h1:rLIhh7DvifVLmf2QxMr/vMRGqdrTZazn8VYo4LilfCo=
+github.com/databricks/databricks-sdk-go v0.40.0 h1:H9KAyRbM5lwnY8t9nY/xAYHVTBsLqFuIRwVaRGqYJe0=
+github.com/databricks/databricks-sdk-go v0.40.0/go.mod h1:Yjy1gREDLK65g4axpVbVNKYAHYE2Sqzj0AB9QWHCBVM=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=

go.work.sum

@@ -307,6 +307,8 @@ github.com/cncf/xds/go v0.0.0-20231128003011-0fa0005c9caa/go.mod h1:x/1Gn8zydmfq
 github.com/coreos/go-semver v0.3.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk=
 github.com/coreos/go-systemd/v22 v22.3.2/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=
 github.com/databricks/databricks-sdk-go v0.26.1/go.mod h1:cyFYsqaDiIdaKPdNAuh+YsMUL1k9Lt02JB/72+zgCxg=
+github.com/databricks/databricks-sdk-go v0.40.0 h1:H9KAyRbM5lwnY8t9nY/xAYHVTBsLqFuIRwVaRGqYJe0=
+github.com/databricks/databricks-sdk-go v0.40.0/go.mod h1:Yjy1gREDLK65g4axpVbVNKYAHYE2Sqzj0AB9QWHCBVM=
 github.com/envoyproxy/go-control-plane v0.9.9-0.20201210154907-fd9021fe5dad/go.mod h1:cXg6YxExXjJnVBQHBLXeUAgxn2UodCpnH306RInaBQk=
 github.com/envoyproxy/go-control-plane v0.9.9-0.20210217033140-668b12f5399d/go.mod h1:cXg6YxExXjJnVBQHBLXeUAgxn2UodCpnH306RInaBQk=
 github.com/envoyproxy/go-control-plane v0.9.10-0.20210907150352-cf90f659a021/go.mod h1:AFq3mo9L8Lqqiid3OhADV3RfLJnjiw63cSpi+fDTRC0=

metascan/go.mod

@@ -4,7 +4,7 @@ go 1.21.0
 
 require (
 	github.com/adrg/frontmatter v0.2.0
-	github.com/databricks/databricks-sdk-go v0.41.0
+	github.com/databricks/databricks-sdk-go v0.40.0
 	github.com/databrickslabs/sandbox/go-libs v0.2.0
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.9.0