Skip to content

E2E POC for python telemetry for connect logs #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 269 commits into from
Jun 10, 2025
Merged

E2E POC for python telemetry for connect logs #581

merged 269 commits into from
Jun 10, 2025

Conversation

saishreeeee
Copy link
Collaborator

@saishreeeee saishreeeee commented Jun 3, 2025 •
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Added TelemetryClient and TelemetryClientFactory
Added functionality to export initial telemetry logs

How is this tested?

  • Unit tests
    Added unit tests to check the functionality of telemetry client and telemetry client factory
  • E2E Tests
  • Manually
    Ran a query that triggered the export of initital telemetry log, verified that the log was present in the target table
  • N/A

Related Tickets & Documents

PECOBLR-457

@saishreeeee saishreeeee marked this pull request as draft June 3, 2025 02:51
@saishreeeee saishreeeee marked this pull request as ready for review June 3, 2025 05:05
@saishreeeee saishreeeee self-assigned this Jun 3, 2025
vikrantpuppala
vikrantpuppala reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@vikrantpuppala vikrantpuppala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we break down this PR further please? let's start with simple connect logs, then error logs and then latency logs

@saishreeeee saishreeeee changed the title E2E POC for python telemetry for connect + latency + error logs E2E POC for python telemetry for connect logs Jun 3, 2025
vikrantpuppala
vikrantpuppala reviewed Jun 3, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@saishreeeee
added log statements
5f8dff5 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed TelemetryClientFactory to a static class and made changes in …
906c187 
…unit tests accordingly

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
added lock in TelemetryClientFactory and specified dict type in _client
f6bd9ad 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed type of attribute _executor in TelemetryClientFactory
c47bc73 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
removed discovery_url
4a2386b 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
vikrantpuppala
vikrantpuppala reviewed Jun 9, 2025
View reviewed changes
@saishreeeee
removed unused params from driver connection params, initialize_telem…
e4c05d1 
…etry_client does not return a telemetry client

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
renamed other as client_cert in auth_mech
bf92c6c 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
jprakash-db
jprakash-db reviewed Jun 9, 2025
View reviewed changes
@saishreeeee
lazy logging, renamed private variables, defined telemetry endpoints …
e218ef9 
…as constants, added callback function while submitting request to executor, changed del to pop

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed unittest to pytest
9615519 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
shifted EnumEncoder to telemetry/utils.py
c084846 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed type of _clients in TelemetryClientFactory
7394295 
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
jprakash-db
jprakash-db approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@jprakash-db jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes.

@saishreeeee saishreeeee merged commit 9dc7d52 into telemetry Jun 10, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jprakash-db jprakash-db jprakash-db approved these changes

@deeksha-db deeksha-db Awaiting requested review from deeksha-db deeksha-db is a code owner

@samikshya-db samikshya-db Awaiting requested review from samikshya-db samikshya-db is a code owner

@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db jackyhu-db is a code owner

@madhav-db madhav-db Awaiting requested review from madhav-db madhav-db is a code owner

@gopalldb gopalldb Awaiting requested review from gopalldb gopalldb is a code owner

@jayantsing-db jayantsing-db Awaiting requested review from jayantsing-db jayantsing-db is a code owner

@shivam2680 shivam2680 Awaiting requested review from shivam2680 shivam2680 is a code owner

@vikrantpuppala vikrantpuppala Awaiting requested review from vikrantpuppala vikrantpuppala is a code owner

Assignees

@saishreeeee saishreeeee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.