Merged
Conversation
f9a11e2 to
65efc20
Compare
Signed-off-by: Shivam Raj <shivam.raj@databricks.com>
65efc20 to
5a113cb
Compare
vikrantpuppala
previously approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for metric view metadata in the Databricks SQL Go driver, enabling getTables(), getTableTypes(), and getColumns() to return METRIC_VIEW entries when enabled. The feature is disabled by default for backward compatibility.
- Added
EnableMetricViewMetadataconfiguration parameter with DSN parsing and connector option support - Session automatically injects the required Spark configuration when enabled
- Added comprehensive unit tests verifying enabled and disabled states
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/config/config.go | Added EnableMetricViewMetadata field to UserConfig with DSN parsing support |
| connector.go | Implemented session configuration injection and WithEnableMetricViewMetadata option |
| connector_test.go | Added tests for enabled and default disabled states |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gopalldb
previously approved these changes
Oct 23, 2025
Collaborator
gopalldb
left a comment
There was a problem hiding this comment.
Check suggestions from copilot
Address PR review comments by simplifying the session configuration logic. Always create a new map and copy existing params regardless of whether metric view metadata is enabled. This makes the code cleaner and more consistent: - No nil check needed (ranging over nil map is safe in Go) - Consistent behavior in all cases - More readable code Resolves reviewer comments from @vikrantpuppala, @copilot-pull-request-reviewer, and @gopalldb Signed-off-by: Shivam Raj <shivam.raj@databricks.com>
3edd436
gopalldb
approved these changes
Oct 24, 2025
dgiagio
pushed a commit
to grafana/databricks-sql-go
that referenced
this pull request
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for metric view metadata in the Databricks SQL Go driver, following the JDBC driver implementation.
Changes
EnableMetricViewMetadataboolean configuration parameter toUserConfigenableMetricViewMetadataquery parameterWithEnableMetricViewMetadata(bool)connector optionspark.sql.thriftserver.metadata.metricview.enabled=truewhen enabledBehavior
When
EnableMetricViewMetadata=true:getTables()andgetTableTypes()will include METRIC_VIEW entriesgetColumns()will return measure columns with<data_type> measureformat in TYPE_NAMEUsage
Testing
All unit tests pass including 2 new tests for this feature.
Backward Compatibility
Feature is disabled by default - fully backward compatible.