Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional dependencies #159

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Added additional dependencies #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@
<data.stream.parent>system:cdap-data-streams[6.8.0-SNAPSHOT, 7.0.0-SNAPSHOT)</data.stream.parent>
<hadoop.version>2.10.2</hadoop.version>
<aws.sdk.version>1.11.133</aws.sdk.version>
<jackson.version>2.12.7.1</jackson.version>
<commons.logging.version>1.2</commons.logging.version>
<commons.httpcomponents.version>4.5.13</commons.httpcomponents.version>
<main.basedir>${project.basedir}</main.basedir>
</properties>

Expand Down Expand Up @@ -260,6 +263,21 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use dependencyManagement to overwrite transitive dependency versions? Then we can also remove the manual exclusions we did as part of the vulnerability fixes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the dependences versions were missing from the JAR due to previous exclusions.

Copy link
Contributor

@dli357 dli357 Feb 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, in that case dependencyManagement can allow us to overwrite those transitive dependencies without having to manually include them, i.e. we can remove the exclusions added in #141.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See cdapio/hydrator-plugins#1747 for an example.

<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>${commons.logging.version}</version>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<version>${commons.httpcomponents.version}</version>
</dependency>
</dependencies>

<build>
Expand All @@ -278,7 +296,7 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>2.5.4</version>
<version>3.5.0</version>
<extensions>true</extensions>
<configuration>
<instructions>
Expand Down