Skip to content

fix(renderer): allow negative numbers in dataType #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented May 18, 2022

Fixes #1256

Description

We didn't include - in the pattern.

Schema

const schema = {
  title: 'Sequence condition',
  fields: [
    {
      component: 'text-field',
      name: 'field-1',
      label: 'first name',
      dataType: 'integer',
    },
  ],
};

@rvsia rvsia added bug Something isn't working renderer React form renderer PR labels May 18, 2022
@rvsia rvsia requested a review from Hyperkid123 May 18, 2022 12:47
@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.18.1 [DataDrivenFormsBot]

@rvsia rvsia force-pushed the allowNegativeNumbers branch from 5eb771e to 03b0291 Compare May 18, 2022 12:54
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1257 (03b0291) into master (79433d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1257   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         209      209           
  Lines        3623     3623           
  Branches     1264     1264           
=======================================
  Hits         3443     3443           
  Misses        180      180           
Impacted Files Coverage Δ
...orm-renderer/src/validators/validator-functions.js 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rvsia rvsia merged commit fe6c791 into data-driven-forms:master May 18, 2022
@rvsia rvsia added the released label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When use dataType=dataTypes.NUMBER, the validation should allow negative number
3 participants