chore(renderer): add tests for name condition trigger extractor

Author: Hyperkid123

packages/react-form-renderer/src/form-renderer/render-form.js

@@ -2,59 +2,8 @@ import React, { useContext } from 'react';
 import PropTypes from 'prop-types';
 import RendererContext from '../renderer-context';
 import Condition from '../condition';
-import { memoize } from '../common/helpers';
 import { Field } from 'react-final-form';
-
-const mergeFunctionTrigger = (fn, field) => {
-  let internalTriggers = [];
-  const internalWhen = fn(field);
-  if (Array.isArray(internalWhen)) {
-    internalTriggers = [...internalWhen];
-  } else {
-    internalTriggers.push(internalWhen);
-  }
-
-  return internalTriggers;
-};
-
-const getConditionTriggers = memoize((condition, field) => {
-  let triggers = [];
-  if (Array.isArray(condition)) {
-    return condition.reduce((acc, item) => [...acc, ...getConditionTriggers(item, field)], []);
-  }
-
-  const {when, ...rest} = condition;
-  const nestedKeys = ['and', 'or', 'sequence'];
-  if (typeof when === 'string') {
-    triggers = [...triggers, when];
-  }
-
-  if (typeof when === 'function') {
-    triggers = [...triggers, ...mergeFunctionTrigger(when, field)];
-  }
-
-  if (Array.isArray(when)) {
-    when.forEach(item => {
-      if (typeof item === 'string') {
-        triggers = [...triggers, item];
-      }
-
-      if (typeof item === 'function') {
-        triggers = [...triggers, ...mergeFunctionTrigger(item, field)];
-      }
-    });
-  }
-
-  nestedKeys.forEach(key => {
-    if (typeof rest[key] !== 'undefined') {
-    rest[key].forEach(item => {
-      triggers = [...triggers, ...getConditionTriggers(item, field)];
-    });
-    }
-  });
-
-  return Array.from(new Set(triggers));
-});
+import getConditionTriggers from '../get-condition-triggers';
 
 const FormFieldHideWrapper = ({ hideField, children }) => (hideField ? <div hidden>{children}</div> : children);
 

packages/react-form-renderer/src/get-condition-triggers/get-condition-triggers.d.ts

@@ -0,0 +1,5 @@
+import { ConditionDefinition } from "../../condition";
+
+declare function getConditionTriggers(params:ConditionDefinition | ConditionDefinition[]): string[];
+
+export default getConditionTriggers;

packages/react-form-renderer/src/get-condition-triggers/get-condition-triggers.js

@@ -0,0 +1,54 @@
+import { memoize } from '../common';
+
+const mergeFunctionTrigger = (fn, field) => {
+  let internalTriggers = [];
+  const internalWhen = fn(field);
+  if (Array.isArray(internalWhen)) {
+    internalTriggers = [...internalWhen];
+  } else {
+    internalTriggers.push(internalWhen);
+  }
+
+  return internalTriggers;
+};
+
+const getConditionTriggers = memoize((condition, field) => {
+  let triggers = [];
+  if (Array.isArray(condition)) {
+    return condition.reduce((acc, item) => [...acc, ...getConditionTriggers(item, field)], []);
+  }
+
+  const {when, ...rest} = condition;
+  const nestedKeys = ['and', 'or', 'sequence'];
+  if (typeof when === 'string') {
+    triggers = [...triggers, when];
+  }
+
+  if (typeof when === 'function') {
+    triggers = [...triggers, ...mergeFunctionTrigger(when, field)];
+  }
+
+  if (Array.isArray(when)) {
+    when.forEach(item => {
+      if (typeof item === 'string') {
+        triggers = [...triggers, item];
+      }
+
+      if (typeof item === 'function') {
+        triggers = [...triggers, ...mergeFunctionTrigger(item, field)];
+      }
+    });
+  }
+
+  nestedKeys.forEach(key => {
+    if (typeof rest[key] !== 'undefined') {
+    rest[key].forEach(item => {
+      triggers = [...triggers, ...getConditionTriggers(item, field)];
+    });
+    }
+  });
+
+  return Array.from(new Set(triggers));
+});
+
+export default getConditionTriggers;

packages/react-form-renderer/src/get-condition-triggers/index.d.ts

@@ -0,0 +1 @@
+export { default } from './get-condition-triggers';

packages/react-form-renderer/src/get-condition-triggers/index.js

@@ -0,0 +1 @@
+export { default } from './get-condition-triggers';

packages/react-form-renderer/src/tests/get-condition-triggers/get-condition-triggers.test.js

@@ -0,0 +1,35 @@
+import getConditionTriggers from '../../get-condition-triggers';
+
+describe('getConditionTriggers', () => {
+  test('should extract name from simple when definition', () => {
+    expect(getConditionTriggers({ when: 'a' })).toEqual(['a']);
+  });
+
+  test('should extract name from simple when array definition', () => {
+    expect(getConditionTriggers({ when: ['a', 'b'] })).toEqual(['a', 'b']);
+  });
+
+  test('should extract name from simple when function definition', () => {
+    expect(getConditionTriggers({ when: () => 'a' })).toEqual(['a']);
+  });
+
+  test('should extract name from combined when array definition', () => {
+    expect(getConditionTriggers({ when: ['a', () => 'b'] })).toEqual(['a', 'b']);
+  });
+
+  test('should extract name from combined when array definition if functions returns an array', () => {
+    expect(getConditionTriggers({ when: ['a', () => ['b', 'c']] })).toEqual(['a', 'b', 'c']);
+  });
+
+  test('should extract name from and condition definition', () => {
+    expect(getConditionTriggers({ and: [{ when: 'a' }, {when: ['b', 'c']}, { when: () => 'd' }] })).toEqual(['a', 'b', 'c', 'd']);
+  });
+
+  test('should extract name from or condition definition', () => {
+    expect(getConditionTriggers({ or: [{ when: 'a' }, {when: ['b', 'c']}, { when: () => 'd' }] })).toEqual(['a', 'b', 'c', 'd']);
+  });
+
+  test('should extract name from array of conditions', () => {
+    expect(getConditionTriggers([{ when: 'a' }, {when: 'b'}])).toEqual(['a', 'b']);
+  });
+});