Skip to content

fix: update type signature of eigh #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

Saransh-cpp
Copy link
Contributor

@Saransh-cpp Saransh-cpp commented Apr 9, 2025

Fixes #922

The type signature of eigh has been updated from Tuple[array] to Tuple[array, array].

I am not sure how things are backported in this repository, but for now I have updated the signature in all the versions. Please let me know if this should be changed!

Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Saransh-cpp, LGTM!

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte changed the title TYP: fix type signature of eigh fix: update type signature of eigh May 12, 2025
@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. Backport Changes involve backporting to previous versions. labels May 12, 2025
@kgryte kgryte added this to the v2025 milestone May 12, 2025
@kgryte kgryte merged commit f9cf531 into data-apis:main May 12, 2025
2 checks passed
@Saransh-cpp Saransh-cpp deleted the saransh/fix-type-eigh branch May 12, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Changes involve backporting to previous versions. Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong return type for linalg.eigh in function signature
3 participants