Skip to content

Categoricals #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2016
Merged

Categoricals #7

merged 2 commits into from
May 4, 2016

Conversation

mrocklin
Copy link
Member

@mrocklin mrocklin commented May 3, 2016

@lminer
Copy link

lminer commented May 3, 2016

huzzah!

categories = [b.categories if isinstance(b, pd.Categorical) else None
for b in blocks]
blocks = [b.codes if isinstance(b, pd.Categorical) else b
for b in blocks]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Categoricals can also be ordered (Boolean default False)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved. FYI I ran into an issue that assert_frame_equal did not pick up on the ordered difference between two Categorical objects.

In [1]: import pandas as pd

In [2]: pd.util.testing.assert_frame_equal(pd.DataFrame({'x': pd.Categorical([], ordered=True)}), pd.DataFrame({'x': pd.Categorical([], ordered=False)}))

In [3]: 

@lminer
Copy link

lminer commented May 5, 2016

Are you planning on a new release soon to pull in this change or should I install the master branch?

@mrocklin
Copy link
Member Author

mrocklin commented May 6, 2016

I would like to issue a general dask release sometime late next week.
Perhaps install master branch until then? If it's important I can also
issue a smaller release now.

On Thu, May 5, 2016 at 2:50 PM, Luke Miner notifications@github.com wrote:

Are you planning on a new release soon to pull in this change or should I
install the master branch?


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#7 (comment)

@lminer
Copy link

lminer commented May 6, 2016

Not important. Just checking. Thanks a bunch!

@mrocklin
Copy link
Member Author

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants