Fix spans bug when scatter or client_desires_new_key creates a task #7886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
changed the title
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 11h 29m 19s ⏱️ - 1h 7m 51s For more details on these failures and errors, see this check. Results for commit de55a46. ± Comparison against base commit 743826b. ♻️ This comment has been updated with latest results. |
hendrikmakait
approved these changes
Jun 7, 2023
|
|
||
| @gen_cluster(client=True) | ||
| async def test_scatter_creates_ts(c, s, a, b): | ||
| """A TaskState object is created by scatter, and only later becomes runnable |
There was a problem hiding this comment.
OOT: It's mildly scary that this is even legitimate behavior.
There was a problem hiding this comment.
To be frank I think that the whole scatter design and implementation should be levelled and redone from scratch
Co-authored-by: Hendrik Makait <hendrik@makait.com>
commit b25afdc6d499a7b2c424579a3378bb0e5849d2e7
Author: crusaderky <crusaderky@gmail.com>
Date: Wed Jun 7 00:08:06 2023 +0100
f
commit d75c8faebfc136701b62ace152f04cc9cd9e3427
Author: crusaderky <crusaderky@gmail.com>
Date: Wed Jun 7 00:02:57 2023 +0100
Post fine performance metrics to spans
commit 640bda91adfe74874b445a2ed2d389e1b2f8bbd6
Author: crusaderky <crusaderky@gmail.com>
Date: Wed Jun 7 00:04:01 2023 +0100
Fix spans bug when scatter or client_desires_new_key creates a task
Merge branch 'main'
Conflicts:
distributed/scheduler.py
distributed/spans.py
distributed/tests/test_spans.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of the whole test suite, this use case was triggered (not always) exclusively by test_queue.py::test_race.