Use pip install . instead of calling setup.py
#5442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is almost the same but is more consistent and future proof
jacobtomlinson
approved these changes
Oct 19, 2021
jrbourbeau
reviewed
Oct 19, 2021
There was a problem hiding this comment.
Thanks for the update @Carreau. While we're changing this line anways, maybe we should use python -m pip too? I think that's the recommended way of doing things today
Carreau
commented
Oct 19, 2021
|
As long as we don't invoke setup.py directly, I'm fine. I don't have a particular opinion. |
jrbourbeau
approved these changes
Oct 19, 2021
|
Thanks ! |
zanieb
pushed a commit
to zanieb/distributed
that referenced
this pull request
Oct 28, 2021
It is almost the same but is more consistent and future proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is almost the same but is more consistent and future proof.