Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle management for Prometheus metrics #7385

Open
hendrikmakait opened this issue Dec 9, 2022 · 6 comments
Open

Lifecycle management for Prometheus metrics #7385

hendrikmakait opened this issue Dec 9, 2022 · 6 comments
Labels
diagnostics discussion Discussing a topic with no specific actions yet

Comments

@hendrikmakait
Copy link
Member

As mentioned in #7374 (comment), we do not have any lifecycle management for Prometheus metrics. On the one hand, most metrics are under active development, so additions or breaking changes are to be expected (e.g., #7368). On the other hand, some metrics have been around for quite a while and might be used in a production setting but might not correspond to guidelines we establish and require changes (e.g., #7374).

This raises the following questions:

  • How do we perform lifecycle management for Prometheus metrics?
  • Are there any best practices we should follow?
  • What are the expectations toward stability?
  • Should we version metrics (and how would we)?
@hendrikmakait hendrikmakait added diagnostics discussion Discussing a topic with no specific actions yet labels Dec 9, 2022
@crusaderky
Copy link
Collaborator

cc @jacobtomlinson @fjetter

@mrocklin
Copy link
Member

Personally I'd be ok with a hard break if we come up with a structure that we're happy living with for a while.

Prometheus usage is, as far as I can tell, sporadic today. If a hard break helps us to make it useful and widespread then I would be ok with that.

cc also @jacobtomlinson

@jacobtomlinson
Copy link
Member

I agree that I'm pretty happy to break things now, but I'd like to avoid breaking things again in the future if prometheus usage is going to increase.

Versioning somehow would be nice, but also adds a bunch of overhead. I've not seen this done in practice.

@dchudz
Copy link
Contributor

dchudz commented Jan 30, 2023

@gjoseph92 summarizing our in-person discussion:

I think you're planning on working on this soon, with an approach that shouldn't take more than a week or so of engineering effort.

I also think you'll circulate a design/plan this with, in order to get buy-in from Florian etc.

Right?

@gjoseph92
Copy link
Collaborator

I'll be working on #7364, not this issue. I won't be changing any metrics in the process.

@dchudz
Copy link
Contributor

dchudz commented Jan 30, 2023

oh right, sorry Gabe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics discussion Discussing a topic with no specific actions yet
Projects
None yet
Development

No branches or pull requests

6 participants