Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include BatchedSend state in cluster dumps #6114

Open
gjoseph92 opened this issue Apr 12, 2022 · 0 comments
Open

Include BatchedSend state in cluster dumps #6114

gjoseph92 opened this issue Apr 12, 2022 · 0 comments

Comments

@gjoseph92
Copy link
Collaborator

BatchedSend is known to be brittle, and certain error cases can cause it to drop messages or even shut down entirely, causing deadlocks:

I don't think we've seen these problems actually come up in the wild since #5525.

But when looking over cluster dumps, it would be nice to be able to rule this out as an issue. So I think we should include some minimal information about the state of BatchedSend, such as:

  • len(buffer)
  • please_stop
  • waker.is_set()
  • next_deadline

Obviously it would also be nice to include the status of the coroutine, but since we don't have a handle to it, that's lost to the ether of Tornado.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant