Skip to content

Commit 8a658ee

Browse files
author
Tom Augspurger
authored
Restore signature compatibility for dask-gateway (#6561)
1 parent df1eaba commit 8a658ee

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

distributed/scheduler.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3354,13 +3354,18 @@ def del_scheduler_file():
33543354
setproctitle(f"dask-scheduler [{self.address}]")
33553355
return self
33563356

3357-
async def close(self):
3357+
async def close(self, fast=None, close_workers=None):
33583358
"""Send cleanup signal to all coroutines then wait until finished
33593359
33603360
See Also
33613361
--------
33623362
Scheduler.cleanup
33633363
"""
3364+
if fast is not None or close_workers is not None:
3365+
warnings.warn(
3366+
"The 'fast' and 'close_workers' parameters in Scheduler.close have no effect and will be removed in a future version of distributed.",
3367+
FutureWarning,
3368+
)
33643369
if self.status in (Status.closing, Status.closed):
33653370
await self.finished()
33663371
return

distributed/tests/test_scheduler.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3595,3 +3595,9 @@ async def test_worker_state_unique_regardless_of_address(s, w):
35953595
assert ws1 is not ws2
35963596
assert ws1 != ws2
35973597
assert hash(ws1) != ws2
3598+
3599+
3600+
@gen_cluster(nthreads=[("", 1)])
3601+
async def test_scheduler_close_fast_deprecated(s, w):
3602+
with pytest.warns(FutureWarning):
3603+
await s.close(fast=True)

0 commit comments

Comments
 (0)