Skip to content

Commit 700f14a

Browse files
authored
Add full dashboard link in scheduler logs (#7631)
1 parent 6c85a0c commit 700f14a

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

distributed/node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def start_http_server(
171171
bound_addresses = get_tcp_server_addresses(self.http_server)
172172

173173
# If more than one address is configured we just use the first here
174-
self.http_server.port = bound_addresses[0][1]
174+
self.http_server.address, self.http_server.port = bound_addresses[0]
175175
self.services["dashboard"] = self.http_server
176176

177177
# Warn on port changes

distributed/scheduler.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@
101101
All,
102102
TimeoutError,
103103
empty_context,
104+
format_dashboard_link,
104105
get_fileno_limit,
105106
key_split_group,
106107
log_errors,
@@ -3860,8 +3861,13 @@ async def start_unsafe(self):
38603861

38613862
for listener in self.listeners:
38623863
logger.info(" Scheduler at: %25s", listener.contact_address)
3863-
for k, v in self.services.items():
3864-
logger.info("%11s at: %25s", k, "%s:%d" % (listen_ip, v.port))
3864+
for name, server in self.services.items():
3865+
if name == "dashboard":
3866+
addr = get_address_host(listener.contact_address)
3867+
link = format_dashboard_link(addr, server.port)
3868+
else:
3869+
link = f"{listen_ip}:{server.port}"
3870+
logger.info("%11s at: %25s", name, link)
38653871

38663872
if self.scheduler_file:
38673873
with open(self.scheduler_file, "w") as f:

distributed/tests/test_scheduler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2870,6 +2870,7 @@ async def test_multiple_listeners():
28702870
log = log.getvalue()
28712871
assert re.search(r"Scheduler at:\s*tcp://", log)
28722872
assert re.search(r"Scheduler at:\s*inproc://", log)
2873+
assert re.search(r"dashboard at:\s*http://", log)
28732874

28742875

28752876
@gen_cluster(nthreads=[("127.0.0.1", 1)])

0 commit comments

Comments
 (0)