Skip to content

Commit 1462479

Browse files
Rename get_default_shuffle_algorithm to get_default_shuffle_method (#7902)
Co-authored-by: James Bourbeau <jrbourbeau@gmail.com>
1 parent aca7c02 commit 1462479

File tree

3 files changed

+13
-16
lines changed

3 files changed

+13
-16
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,6 @@ repos:
6363
- pytest
6464
- tornado
6565
- pyarrow
66-
- git+https://github.com/dask/dask
66+
# - git+https://github.com/dask/dask
67+
- git+https://github.com/hendrikmakait/dask.git@default-shuffle-ignores-fuse
6768
- git+https://github.com/dask/zict

continuous_integration/gpuci/build.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,13 @@ gpuci_logger "Activate conda env"
4040
. /opt/conda/etc/profile.d/conda.sh
4141
conda activate dask
4242

43-
gpuci_logger "Install dask"
44-
python -m pip install git+https://github.com/dask/dask
45-
4643
gpuci_logger "Install distributed"
4744
python -m pip install -e .
4845

46+
gpuci_logger "Install dask"
47+
# python -m pip install git+https://github.com/dask/dask
48+
python -m pip install git+https://github.com/hendrikmakait/dask.git@default-shuffle-ignores-fuse
49+
4950
gpuci_logger "Check Python versions"
5051
python --version
5152

distributed/tests/test_client.py

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,7 @@
4040
import dask.bag as db
4141
from dask import delayed
4242
from dask.optimization import SubgraphCallable
43-
from dask.utils import (
44-
get_default_shuffle_algorithm,
45-
parse_timedelta,
46-
stringify,
47-
tmpfile,
48-
)
43+
from dask.utils import get_default_shuffle_method, parse_timedelta, stringify, tmpfile
4944

5045
from distributed import (
5146
CancelledError,
@@ -3229,25 +3224,25 @@ def test_default_get(loop_in_thread):
32293224
# These may change in the future but the selection below should not
32303225
distributed_default = "p2p" if has_pyarrow else "tasks"
32313226
local_default = "disk"
3232-
assert get_default_shuffle_algorithm() == local_default
3227+
assert get_default_shuffle_method() == local_default
32333228
with Client(s["address"], set_as_default=True, loop=loop) as c:
32343229
assert dask.base.get_scheduler() == c.get
3235-
assert get_default_shuffle_algorithm() == distributed_default
3230+
assert get_default_shuffle_method() == distributed_default
32363231

32373232
assert dask.base.get_scheduler() == pre_get
3238-
assert get_default_shuffle_algorithm() == local_default
3233+
assert get_default_shuffle_method() == local_default
32393234

32403235
c = Client(s["address"], set_as_default=False, loop=loop)
32413236
assert dask.base.get_scheduler() == pre_get
3242-
assert get_default_shuffle_algorithm() == local_default
3237+
assert get_default_shuffle_method() == local_default
32433238
c.close()
32443239

32453240
c = Client(s["address"], set_as_default=True, loop=loop)
3246-
assert get_default_shuffle_algorithm() == distributed_default
3241+
assert get_default_shuffle_method() == distributed_default
32473242
assert dask.base.get_scheduler() == c.get
32483243
c.close()
32493244
assert dask.base.get_scheduler() == pre_get
3250-
assert get_default_shuffle_algorithm() == local_default
3245+
assert get_default_shuffle_method() == local_default
32513246

32523247
with Client(s["address"], loop=loop) as c:
32533248
assert dask.base.get_scheduler() == c.get

0 commit comments

Comments
 (0)