File tree Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -8485,7 +8485,13 @@ def coassignmnet_groups(
8485
8485
while len (next .dependents ) == 1 :
8486
8486
dep = list (next .dependents )[0 ]
8487
8487
if len (dep .dependencies ) != 1 :
8488
- # This algorithm has the shortcoming that groups may grow too large if the dependent of a group
8488
+ # This algorithm has the shortcoming that groups may grow
8489
+ # too large if we walk straight to the dependent of a group.
8490
+ # Especially in staged reductions (e.g. tree reductions, the
8491
+ # next "jump" would combine multiple cogroups). For now,
8492
+ # just ignore these. This means that we'll practically only
8493
+ # have cogroups at the bottom of a graph but this is where
8494
+ # it matters the most anyhow
8489
8495
group_dependents_seen .add (dep )
8490
8496
break
8491
8497
next = dep
You can’t perform that action at this time.
0 commit comments