Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoration fails when no dashboard is connected #216

Closed
ian-r-rose opened this issue Dec 20, 2021 · 0 comments · Fixed by #217
Closed

Restoration fails when no dashboard is connected #216

ian-r-rose opened this issue Dec 20, 2021 · 0 comments · Fixed by #217

Comments

@ian-r-rose
Copy link
Collaborator

An unintended consequence of #198. We are being fairly aggressive about disposing of dashboard panels that don't match up with one of the ones in individual-charts.json. But since we removed the default dashboard panels in #198, this means that upon restoration if there is no active cluster, the panels will be removed. Among other things, this prevents the "initial layout" trick we use in dask-examples.

To reproduce:

  1. Start a cluster
  2. Connect to the cluster using the labextension side panel
  3. Open a few dashboard panels
  4. Refresh the page. Your panels should be restored.
  5. Shut down the cluster. The panels will be deactivated, but won't go away.
  6. Refresh the page. The panels will not be restored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant