Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI not using set Python versions #140

Open
jacobtomlinson opened this issue Aug 4, 2020 · 0 comments
Open

CI not using set Python versions #140

jacobtomlinson opened this issue Aug 4, 2020 · 0 comments
Labels

Comments

@jacobtomlinson
Copy link
Member

As noted in #138 it appears the CI is configured to test against Python 3.6 and 3.7. However things are getting upgraded to 3.8 every time.

This caused a problem as pytest was being pinned to 3.7 and 3.8 became the default Python version. But the current config would never have worked for 3.6 anyway as if it were correctly testing against 3.6 the pytest at 3.7 would have failed.

Things to fix here:

  • Conda is complaining about the shell not being activated correctly. Despite .bashrc being sourced.
  • The conda create in bash_install.sh isn't pinning the Python version correctly.
  • We should also add 3.8 tests once above is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant