Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating authors #223

Closed
jakirkham opened this issue May 13, 2021 · 8 comments · Fixed by #225
Closed

Updating authors #223

jakirkham opened this issue May 13, 2021 · 8 comments · Fixed by #225

Comments

@jakirkham
Copy link
Member

Currently this file lists only me. However other people have been contributing here. It would be great to have a more comprehensive list.

Also other projects tend to call this CONTRIBUTORS.txt. I think AUTHORS.rst just came from a Python project template tool. So it might be worth renaming.

Independently some of the source files have __author__ and __email__. The email referenced is dead and as already noted we have more people contributing. We might want to strip these out.

Not sure what other relevant changes we might want to include, but feel free to suggest.

@GenevieveBuckley
Copy link
Collaborator

  1. I absolutely do not want to spend time maintaining an author/contributor list by hand. I thought linking to the contributors page on github would be a good way around that? DOCS: Update information in AUTHORS.rst #166

  2. I don't mind what this file is called. To be honest, I don't mind whether this file exists at all, since this information is easily available at https://github.com/dask/dask-image/graphs/contributors

  3. Yes, stripping out __author__ and __email__ sounds like a good idea. Even aside from the fact these things go out of date, the implication an email might be required is a real disincentive to contribute (why would anyone want to hand strangers more avenues to potentially harass them?)

@grlee77
Copy link
Contributor

grlee77 commented May 14, 2021

Just relying on the GitHub contributors page is also be fine by me. From the command line, one can run something like git shortlog --summary --numbered --email to get similar info.

@jakirkham
Copy link
Member Author

I absolutely do not want to spend time maintaining an author/contributor list by hand. I thought linking to the contributors page on github would be a good way around that?

I thought we could ask people to add themselves. We do this in Zarr for example. That said, I don't feel strongly about it. Some people do like the credit though

@GenevieveBuckley
Copy link
Collaborator

I thought we could ask people to add themselves.

That was the original situation here too, but no-one ever updated that file.

That said, I don't feel strongly about it. Some people do like the credit though

Sure, some people do like credit. I'm happy to highlight the github contributors page, I think that fills this function.

I'm more worried about creating only crediting some contributors & not others with a manually updated list. That feels more fraught.

@GenevieveBuckley
Copy link
Collaborator

Ok, I'll make a PR to remove the __author__ and __email__ lines.

Your old email address still appears in the setup.py file, not sure if you want that changed to something else @jakirkham

author_email="kirkhamj@janelia.hhmi.org",

@jakirkham
Copy link
Member Author

Your old email address still appears in the setup.py file, not sure if you want that changed to something else @jakirkham

Feel free to drop that one as well. Would much rather users come to GitHub than email

The author field can probably be made more inclusive like "dask-image contributors" or similar

@GenevieveBuckley
Copy link
Collaborator

Ok, done

@jakirkham
Copy link
Member Author

I thought we could ask people to add themselves.

That was the original situation here too, but no-one ever updated that file.

That said, I don't feel strongly about it. Some people do like the credit though

Sure, some people do like credit. I'm happy to highlight the github contributors page, I think that fills this function.

I'm more worried about creating only crediting some contributors & not others with a manually updated list. That feels more fraught.

Yeah that makes sense. If people are not doing this themselves, then agree we shouldn't try to maintain the list ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants