Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observations from 2021.8.1 automatic release #180

Open
4 of 5 tasks
jrbourbeau opened this issue Aug 21, 2021 · 7 comments
Open
4 of 5 tasks

Observations from 2021.8.1 automatic release #180

jrbourbeau opened this issue Aug 21, 2021 · 7 comments

Comments

@jrbourbeau
Copy link
Member

jrbourbeau commented Aug 21, 2021

A couple unexpected things happened with the latest automatic release procedure:

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Aug 21, 2021

For reference, since our build workflow will push to docker hub on push events with a new tag

push: ${{ github.repository == 'dask/dask-docker' && github.event_name == 'push' && startsWith(github.ref, 'refs/tags') }}

I ended up manually deleting the 2021.8.1 tag (which was generated from the autotag workflow) and pushing an empty commit to main with a new 2021.8.1 tag (3362618). This resulted in docker images for the new release being published

@jacobtomlinson
Copy link
Member

Thanks for writing this up @jrbourbeau. I'll take a look at these.

@jakirkham
Copy link
Member

Curious how many of these are still issues

@jrbourbeau
Copy link
Member Author

IIUC all of the unchecked boxes in the original post are still valid

@jacobtomlinson
Copy link
Member

jacobtomlinson commented Mar 23, 2022

I've fixed up a few things and checked a few boxes in the post above that I can confirm as resolved.

The last outstanding one is the auto merge, I'm not sure if this is fixed by the other changes I've made so let's wait until the next release and see what happens. cc @jrbourbeau @jsignell.

@jacobtomlinson
Copy link
Member

ping @jrbourbeau @jsignell how did things go with the latest release?

I see some extra changes were pushed to the PR so I'm guessing the find and replace still isn't working quite right, and the automerge didn't work. Is there anything else?

@jrbourbeau
Copy link
Member Author

Yeah, that's correct. I also noticed that the autotag workflow did assign a 2022.4.0 tag, but assigning that tag didn't result in us pushing Docker images to Docker Hub or ghcr.io. As of now the latest images available are for 2022.3.0. I should also note that deleted the 2022.4.0 tag which was automatically added and manually re-added the tag myself to see if that would help, but it did not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants