Fix the fugue dependency #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-braun
force-pushed
the
bugfix/fugue-integration
branch
from
7c082d8 to
a210045
Compare
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
===========================================
- Coverage 100.00% 99.89% -0.11%
===========================================
Files 49 49
Lines 1884 1882 -2
Branches 250 250
===========================================
- Hits 1884 1880 -4
- Misses 0 2 +2
Continue to review full report at Codecov.
|
demianw
added a commit
to NeuroLang/dask-sql
that referenced
this pull request
Feb 8, 2021
commit e5fac1a Author: Nils Braun <nils-braun@users.noreply.github.com> Date: Sun Feb 7 16:20:55 2021 +0100 Aggregate improvements and SQL compatibility (dask-contrib#134) * A lot of refactoring the the groupby. Mainly to include both distinct and null-grouping * Test for non-dask aggregations * All NaN data needs to go into the same partition (otherwise we can not sort) * Fix compatibility with SQL on null-joins * Distinct is not needed, as it is optimized away from Calcite * Implement is not distinct * Describe new limitations and remove old ones * Added compatibility test from fugue * Added a test for sorting with multiple partitions and NaNs * Stylefix commit 7273c2d Author: Nils Braun <nils-braun@users.noreply.github.com> Date: Sun Feb 7 15:34:55 2021 +0100 Docs improvements (dask-contrib#132) * Fixed a bug in function references in docs * More details on the dask-sql internals commit bdc518e Author: Nils Braun <nils-braun@users.noreply.github.com> Date: Sun Feb 7 14:19:50 2021 +0100 Fix the fugue dependency (dask-contrib#133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an update to fugue which breaks the fugue integration, so I pin the version.