fix(spv/storage): return None for heights below sync_base_height when base > 0 in MemoryStorageManager::get_header\n\nPrevents incorrect header lookup by avoiding implicit storage-index interpretation for absolute heights below the checkpoint base; aligns in-memory behavior with absolute height semantics.

Author: PastaPastaPasta

dash-spv/src/storage/memory.rs

@@ -160,13 +160,16 @@ impl StorageManager for MemoryStorageManager {
             _ => 0u32,
         };
 
-        // If height >= base, treat as absolute; else accept it as a storage index for compatibility
-        let idx = if base > 0 && height >= base {
+        // If a base is present and the requested height is below the base, no header exists.
+        if base > 0 && height < base {
+            return Ok(None);
+        }
+        // Map absolute height to storage index
+        let idx = if base > 0 {
             (height - base) as usize
         } else {
             height as usize
         };
-
         Ok(self.headers.get(idx).copied())
     }