Skip to content

Commit 628e939

Browse files
fix(dash-spv): resolve clippy manual_is_multiple_of warnings
Replace manual modulo checks with is_multiple_of() method: - client/mod.rs: Progress logging every 50,000 headers - storage/disk.rs: Periodic segment saves every 1,000 headers - chain/checkpoint_test.rs: Masternode list generation every 100,000 blocks - storage/sync_state.rs: Height interval checking - sync/headers.rs: Progress logging every 10,000 headers - sync/headers_with_reorg.rs: Progress logging every 50,000 headers 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 4d1e3f5 commit 628e939

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

dash-spv/src/chain/checkpoint_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ mod tests {
2222
target: Target::from_compact(CompactTarget::from_consensus(0x1d00ffff)),
2323
merkle_root: Some(BlockHash::from_raw_hash(hash_bytes)),
2424
chain_work: format!("0x{:064x}", height * 1000),
25-
masternode_list_name: if height % 100000 == 0 && height > 0 {
25+
masternode_list_name: if height.is_multiple_of(100000) && height > 0 {
2626
Some(format!("ML{}__70230", height))
2727
} else {
2828
None

dash-spv/src/client/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1816,7 +1816,7 @@ impl<
18161816
}
18171817

18181818
// Progress logging for large header counts
1819-
if loaded_count % 50_000 == 0 || loaded_count == target_height {
1819+
if loaded_count.is_multiple_of(50_000) || loaded_count == target_height {
18201820
let elapsed = start_time.elapsed();
18211821
let headers_per_sec = loaded_count as f64 / elapsed.as_secs_f64();
18221822
tracing::info!(

dash-spv/src/storage/disk.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,7 @@ impl DiskStorageManager {
940940
drop(cached_tip);
941941

942942
// Save dirty segments periodically (every 1000 headers)
943-
if headers.len() >= 1000 || blockchain_height % 1000 == 0 {
943+
if headers.len() >= 1000 || blockchain_height.is_multiple_of(1000) {
944944
self.save_dirty_segments().await?;
945945
}
946946

dash-spv/src/storage/sync_state.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ impl PersistentSyncState {
344344
50000
345345
};
346346

347-
height % interval == 0
347+
height.is_multiple_of(interval)
348348
}
349349
}
350350

dash-spv/src/sync/headers.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ impl HeaderSyncManager {
9494
None => true,
9595
Some(last_time) => {
9696
last_time.elapsed() >= std::time::Duration::from_secs(30)
97-
|| self.total_headers_synced % 10000 == 0
97+
|| self.total_headers_synced.is_multiple_of(10000)
9898
}
9999
};
100100

@@ -407,7 +407,7 @@ impl HeaderSyncManager {
407407

408408
// Headers request sent successfully
409409

410-
if self.total_headers_synced % 10000 == 0 {
410+
if self.total_headers_synced.is_multiple_of(10000) {
411411
tracing::debug!("Requested headers starting from {:?}", base_hash);
412412
}
413413

dash-spv/src/sync/headers_with_reorg.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ impl<S: StorageManager + Send + Sync + 'static, N: NetworkManager + Send + Sync
205205
}
206206

207207
// Progress logging
208-
if loaded_count % 50_000 == 0 || loaded_count == tip_height {
208+
if loaded_count.is_multiple_of(50_000) || loaded_count == tip_height {
209209
let elapsed = start_time.elapsed();
210210
let headers_per_sec = loaded_count as f64 / elapsed.as_secs_f64();
211211
tracing::info!(

0 commit comments

Comments
 (0)