feat: Deterministic Masternode List and Quorum Rotation (DIP24) support (#51)

Author: QuantumExplorer

.github/workflows/fuzz.yml

@@ -39,8 +39,8 @@ jobs:
     steps:
       - name: Install test dependencies
         run: sudo apt-get update -y && sudo apt-get install -y binutils-dev libunwind8-dev libcurl4-openssl-dev libelf-dev libdw-dev cmake gcc libiberty-dev
-      - uses: actions/checkout@v2
-      - uses: actions/cache@v2
+      - uses: actions/checkout@v4
+      - uses: actions/cache@v4
         id: cache-fuzz
         with:
           path: |
@@ -50,13 +50,13 @@ jobs:
           key: cache-${{ matrix.target }}-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.65
+          toolchain: 1.80
           override: true
           profile: minimal
       - name: fuzz
         run: cd fuzz && ./fuzz.sh "${{ matrix.fuzz_target }}"
       - run: echo "${{ matrix.fuzz_target }}" >executed_${{ matrix.fuzz_target }}
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: executed_${{ matrix.fuzz_target }}
           path: executed_${{ matrix.fuzz_target }}
@@ -66,8 +66,8 @@ jobs:
     needs: fuzz
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/download-artifact@v2
+      - uses: actions/checkout@v4
+      - uses: actions/download-artifact@v4
       - name: Display structure of downloaded files
         run: ls -R
       - run: find executed_* -type f -exec cat {} + | sort > executed

.github/workflows/rust.yml

@@ -26,12 +26,12 @@ jobs:
               AS_DEPENDENCY: true
               DO_NO_STD: false
               DO_DOCS: true
-          - rust: 1.65.0
+          - rust: 1.80.0
             env:
               AS_DEPENDENCY: true
     steps:
       - name: Checkout Crate
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Checkout Toolchain
         uses: actions-rs/toolchain@v1
         with:

Cargo.lock

@@ -1,5 +1,6 @@
 [workspace]
 members = ["dash", "hashes", "internals", "fuzz"]
+resolver = "2"
 
 [patch.crates-io.dashcore_hashes]
 path = "hashes"

Cargo.toml

@@ -66,7 +66,7 @@ architectural mismatches.
 
 ## Minimum Supported Rust Version (MSRV)
 
-This library should always compile with any combination of features on **Rust 1.60**.
+This library should always compile with any combination of features on **Rust 1.80**.
 
 ## Installing Rust
 

README.md

@@ -1,6 +1,6 @@
 [package]
 name = "dashcore"
-version = "0.35.0"
+version = "0.36.0"
 authors = [
     "Samuel Westrich <sam@dash.org>",
     "Anton Suprunchuk <anton@dash.org>",
@@ -19,7 +19,7 @@ edition = "2021"
 
 # Please don't forget to add relevant features to docs.rs below
 [features]
-default = [ "std", "secp-recovery", "core-block-hash-use-x11" ]
+default = [ "std", "secp-recovery", "bincode", "quorum_validation" ]
 base64 = [ "base64-compat" ]
 rand-std = ["secp256k1/rand"]
 rand = ["secp256k1/rand"]
@@ -30,6 +30,8 @@ signer = ["secp-recovery", "rand"]
 core-block-hash-use-x11 = ["dashcore_hashes/x11"]
 bls = ["blsful"]
 eddsa = ["ed25519-dalek"]
+quorum_validation = ["bls"]
+bincode = [ "dep:bincode", "dashcore_hashes/bincode" ]
 
 # At least one of std, no-std must be enabled.
 #
@@ -61,11 +63,14 @@ anyhow = { version= "1.0" }
 hex = { version= "0.4" }
 bincode = { version= "2.0.0-rc.3", optional = true }
 bitflags = "2.6.0"
-blsful = { version = "3.0.0-pre8", optional = true }
+blsful = { version = "3.0.0-pre6", optional = true }
 serde_repr = "0.1.19"
 strum = { version = "0.26", features = ["derive"] }
 lazy_static = "1.5.0"
 ed25519-dalek = { version = "2.1", features = ["rand_core"], optional = true }
+blake3 = "1.5"
+thiserror = "1"
+bls-signatures = { git = "https://github.com/dashpay/bls-signatures", branch = "develop" }
 
 [dev-dependencies]
 serde_json = "1.0.96"

dash/Cargo.toml

@@ -4,6 +4,8 @@
 #[cfg(doc)]
 use core::ops::Deref;
 
+#[cfg(feature = "bincode")]
+use bincode::{Decode, Encode};
 use hashes::hex;
 use secp256k1::{Secp256k1, Verification};
 
@@ -26,6 +28,7 @@ use crate::taproot::TapNodeHash;
 ///
 /// [deref coercions]: https://doc.rust-lang.org/std/ops/trait.Deref.html#more-on-deref-coercion
 #[derive(Default, Clone, PartialOrd, Ord, PartialEq, Eq, Hash)]
+#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub struct ScriptBuf(pub Vec<u8>);
 
 impl ScriptBuf {

dash/src/blockdata/script/owned.rs

@@ -34,6 +34,8 @@ pub mod txout;
 
 use core::default::Default;
 
+#[cfg(feature = "bincode")]
+use bincode::{Decode, Encode};
 use hashes::{Hash, sha256d};
 
 use crate::blockdata::constants::WITNESS_SCALE_FACTOR;
@@ -158,6 +160,7 @@ impl<E> EncodeSigningDataResult<E> {
 /// We therefore deviate from the spec by always using the Segwit witness encoding
 /// for 0-input transactions, which results in unambiguously parseable transactions.
 #[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Debug, Hash)]
+#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "serde", serde(crate = "actual_serde"))]
 pub struct Transaction {
@@ -911,6 +914,8 @@ mod tests {
     use crate::blockdata::constants::WITNESS_SCALE_FACTOR;
     use crate::consensus::encode::{deserialize, serialize};
     use crate::internal_macros::hex;
+    use crate::network::message::{NetworkMessage, RawNetworkMessage};
+    use crate::network::message_sml::MnListDiff;
 
     #[test]
     fn test_is_coinbase() {
@@ -1253,6 +1258,18 @@ mod tests {
         assert_eq!(data.len(), 20);
         assert_eq!(&data, &pk_data.as_slice());
     }
+
+    #[test]
+    fn deserialize_serialize_coinbase_transaction_in_dml() {
+        let block_hex = include_str!("../../../tests/data/test_DML_diffs/DML_0_2221605.hex");
+        let data = hex::decode(block_hex).expect("decode hex");
+        let mn_list_diff: RawNetworkMessage = deserialize(&data).expect("deserialize MnListDiff");
+        if let NetworkMessage::MnListDiff(diff) = mn_list_diff.payload {
+            let serialized = serialize(&diff.coinbase_tx);
+            let deserialized: Transaction =
+                deserialize(serialized.as_slice()).expect("expected to deserialize");
+        }
+    }
 }
 
 #[cfg(all(test, feature = "unstable"))]

dash/src/blockdata/transaction/mod.rs

@@ -24,6 +24,8 @@ use core::fmt;
 #[cfg(feature = "std")]
 use std::error;
 
+#[cfg(feature = "bincode")]
+use bincode::{Decode, Encode};
 use hashes::{self, Hash};
 
 use crate::consensus::{Decodable, Encodable, deserialize, encode};
@@ -32,6 +34,7 @@ use crate::io;
 
 /// A reference to a transaction output.
 #[derive(Copy, Clone, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
+#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 pub struct OutPoint {
     /// The referenced transaction's txid.
     pub txid: Txid,

dash/src/blockdata/transaction/outpoint.rs

@@ -22,6 +22,9 @@
 //!
 //! The special transaction type used for AssetLockTx Transactions is 8.
 
+#[cfg(feature = "bincode")]
+use bincode::{Decode, Encode};
+
 use crate::consensus::{Decodable, Encodable, encode};
 use crate::prelude::*;
 use crate::transaction::txout::TxOut;
@@ -35,6 +38,7 @@ use crate::{VarInt, io};
 /// Each TxOut refers to a funding of an Identity.
 ///
 #[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Debug, Hash)]
+#[cfg_attr(feature = "bincode", derive(Encode, Decode))]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "serde", serde(crate = "actual_serde"))]
 pub struct AssetLockPayload {