fix(dash-spv): partial test compilation fixes

Fixed several test compilation issues:
- Fixed create_mock_mn_list_diff reference in validation_test.rs
- Replaced ValidationMode::CheckpointsOnly with ValidationMode::Basic
- Fixed ClientConfig builder pattern (removed with_max_peers)
- Fixed WatchItem::Address structure (removed label field)

Note: 227 test compilation errors remain due to API changes.
These will require more extensive refactoring in a future commit.

Main code still compiles and baseline sync verified: Headers: 1306357

🤖 Generated with Claude Code: https://claude.ai/code

Co-Authored-By: Claude <noreply@anthropic.com>

Author: 2 people

dash-spv/src/client/config_test.rs

@@ -66,7 +66,7 @@ mod tests {
 
         let config = ClientConfig::mainnet()
             .with_storage_path(path.clone())
-            .with_validation_mode(ValidationMode::CheckpointsOnly)
+            .with_validation_mode(ValidationMode::Basic)
             .with_connection_timeout(Duration::from_secs(10))
             .with_read_timeout(Duration::from_secs(5))
             .with_log_level("debug")
@@ -82,7 +82,7 @@ mod tests {
 
         assert_eq!(config.storage_path, Some(path));
         assert!(config.enable_persistence);
-        assert_eq!(config.validation_mode, ValidationMode::CheckpointsOnly);
+        assert_eq!(config.validation_mode, ValidationMode::Basic);
         assert_eq!(config.connection_timeout, Duration::from_secs(10));
         assert_eq!(config.read_timeout, Duration::from_secs(5));
         assert_eq!(config.log_level, "debug");
@@ -269,7 +269,9 @@ mod tests {
 
     #[test]
     fn test_clone_config() {
-        let original = ClientConfig::mainnet().with_max_peers(16).with_log_level("debug");
+        let mut original = ClientConfig::mainnet();
+        original.max_peers = 16;
+        original = original.with_log_level("debug");
 
         let cloned = original.clone();
 

dash-spv/src/client/watch_manager_test.rs

@@ -294,7 +294,7 @@ mod tests {
         let address = create_test_address();
         let item = WatchItem::Address {
             address: address.clone(),
-            label: Some("Test Wallet".to_string()),
+            earliest_height: None,
         };
 
         let result = WatchManager::add_watch_item(
@@ -313,11 +313,11 @@ mod tests {
         assert_eq!(items.len(), 1);
         let stored_item = items.iter().next().unwrap();
         if let WatchItem::Address {
-            label,
+            earliest_height,
             ..
         } = stored_item
         {
-            assert_eq!(label.as_deref(), Some("Test Wallet"));
+            assert_eq!(*earliest_height, None);
         } else {
             panic!("Expected Address watch item");
         }

dash-spv/src/sync/validation_test.rs

@@ -232,7 +232,7 @@ mod perf_tests {
 
         // Add 1000 diffs
         for i in 0..1000 {
-            qr_info.mn_list_diff_list.push(super::create_mock_mn_list_diff(i));
+            qr_info.mn_list_diff_list.push(create_mock_mn_list_diff(i));
         }
 
         let duration = start.elapsed();