clippy fixes

Author: QuantumExplorer

packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs

@@ -34,6 +34,6 @@ fn consensus_or_protocol_value_error(platform_value_error: platform_value::Error
     }
     #[cfg(not(feature = "validation"))]
     {
-        ProtocolError::ValueError(platform_value_error.into())
+        ProtocolError::ValueError(platform_value_error)
     }
 }

packages/rs-dpp/src/errors/consensus/state/token/identity_trying_to_pay_with_wrong_token_error.rs

@@ -39,7 +39,7 @@ impl IdentityTryingToPayWithWrongTokenError {
     }
 
     pub fn expected_contract_id(&self) -> Option<Identifier> {
-        self.expected_contract_id.clone()
+        self.expected_contract_id
     }
 
     pub fn expected_token_contract_position(&self) -> TokenContractPosition {
@@ -51,7 +51,7 @@ impl IdentityTryingToPayWithWrongTokenError {
     }
 
     pub fn actual_contract_id(&self) -> Option<Identifier> {
-        self.actual_contract_id.clone()
+        self.actual_contract_id
     }
 
     pub fn actual_token_contract_position(&self) -> TokenContractPosition {

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/batched_transition/document_base_transition/from_document.rs

@@ -9,6 +9,7 @@ use crate::ProtocolError;
 use platform_version::version::{FeatureVersion, PlatformVersion};
 
 impl DocumentBaseTransition {
+    #[allow(clippy::too_many_arguments)]
     pub fn from_document(
         document: &Document,
         document_type: DocumentTypeRef,

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/batched_transition/document_create_transition/from_document.rs

@@ -8,6 +8,7 @@ use crate::ProtocolError;
 use platform_version::version::{FeatureVersion, PlatformVersion};
 
 impl DocumentCreateTransition {
+    #[allow(clippy::too_many_arguments)]
     pub fn from_document(
         document: Document,
         document_type: DocumentTypeRef,

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/batched_transition/document_delete_transition/from_document.rs

@@ -9,6 +9,7 @@ use crate::state_transition::batch_transition::batched_transition::DocumentDelet
 use crate::tokens::token_payment_info::TokenPaymentInfo;
 
 impl DocumentDeleteTransition {
+    #[allow(clippy::too_many_arguments)]
     pub fn from_document(
         document: Document,
         document_type: DocumentTypeRef,

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/batched_transition/document_purchase_transition/from_document.rs

@@ -10,6 +10,7 @@ use crate::state_transition::batch_transition::batched_transition::DocumentPurch
 use crate::tokens::token_payment_info::TokenPaymentInfo;
 
 impl DocumentPurchaseTransition {
+    #[allow(clippy::too_many_arguments)]
     pub fn from_document(
         document: Document,
         document_type: DocumentTypeRef,

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/batched_transition/document_replace_transition/from_document.rs

@@ -8,6 +8,7 @@ use crate::ProtocolError;
 use platform_version::version::{FeatureVersion, PlatformVersion};
 
 impl DocumentReplaceTransition {
+    #[allow(clippy::too_many_arguments)]
     pub fn from_document(
         document: Document,
         document_type: DocumentTypeRef,

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/batched_transition/document_transfer_transition/from_document.rs

@@ -10,6 +10,7 @@ use platform_value::Identifier;
 use platform_version::version::{FeatureVersion, PlatformVersion};
 
 impl DocumentTransferTransition {
+    #[allow(clippy::too_many_arguments)]
     pub fn from_document(
         document: Document,
         document_type: DocumentTypeRef,

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/batched_transition/document_update_price_transition/from_document.rs

@@ -9,6 +9,7 @@ use crate::state_transition::batch_transition::batched_transition::document_upda
 use crate::tokens::token_payment_info::TokenPaymentInfo;
 
 impl DocumentUpdatePriceTransition {
+    #[allow(clippy::too_many_arguments)]
     pub fn from_document(
         document: Document,
         document_type: DocumentTypeRef,

packages/rs-dpp/src/tokens/token_payment_info/v0/mod.rs

@@ -42,7 +42,7 @@ pub struct TokenPaymentInfoV0 {
     /// If:
     /// - a client does not have this set
     /// - and the data contract allows the price of NFTs to be changed by the data contract's owner or allowed party.
-    /// Then:
+    ///   Then:
     /// - The user could see the cost changed on them
     pub maximum_token_cost: Option<TokenAmount>,
     /// Who pays the gas fees, this needs to match what the contract allows