Multiple updates to DIP8 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents conflicting CLSIGs on temporary chain splits. The code was already using the block height, but the DIP was never updated.
UdjinM6
requested changes
May 3, 2019
Contributor
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
LGTM, just one minor issue
Co-Authored-By: codablock <ablock84@gmail.com>
Collaborator
|
@codablock I'd prefer not to have a dead link in here. Can we either hold this PR until DIP-10 is released or replace the link to it with a placeholder or something? |
Contributor
Author
|
I'm ok with holding this PR until DIP10 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Please note that this already links to DIP10 (LLMQ based InstantSend), even though we don't have it in Github yet.