fix: drop gsl usage from RebuildListFromBlock function wrapper

[UdjinM6]

Issue being fixed or feature implemented

This fixes guix non-determinism for apple-darwin builds.

kudos to knst@ for discovering this

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[knst]

ACK 55220cc

[coderabbitai]

Walkthrough

The pull request modifies the type signature of a lambda parameter used in masternode list diff rebuilding. In both src/init.cpp and src/rpc/evo.cpp, the pindexPrev parameter of the build_list_func callback is changed from gsl::not_null<const CBlockIndex*> to const CBlockIndex* const. This change removes the non-null guarantee and adjusts pointer constness while preserving all surrounding logic and call sites.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify that call sites passing pindexPrev handle potential null pointers correctly after removing the gsl::not_null constraint
• Confirm that the change from gsl::not_null to const CBlockIndex* const is intentional and does not mask any null-safety issues
• Both files follow the same pattern, reducing the need for independent reasoning per file

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing gsl usage from the RebuildListFromBlock function wrapper, which is confirmed by changes to both src/init.cpp and src/rpc/evo.cpp.
Description check	✅ Passed	The PR description is related to the changeset - it mentions fixing guix non-determinism by dropping gsl usage from RebuildListFromBlock, which aligns with the code changes removing gsl::not_null.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}