fix(qt): remove stretchers from Overview page when it's not needed #5992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
reviewed
Apr 23, 2024
UdjinM6
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
utACK (assuming bitcoin-core/gui#176 is going to be backported soon/before v21 release cause otherwise it looks a bit weird when tx list starts to lean left on resize)
knst
changed the title
due to feature_proxy.py failed without IPv6. rebased on the top of develop |
Merged
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Jul 23, 2024
… qt improvements and related fixes 2917c33 partial Merge bitcoin-core/gui#205: Save/restore TransactionView and recentRequestsView tables column sizes (Konstantin Akimov) e5c2c03 Merge bitcoin-core/gui#154: qt: Support macOS Dark mode (MarcoFalke) 29a98c7 Merge bitcoin-core/gui#251: Improve URI/file handling message (MarcoFalke) 48d66fd Merge bitcoin-core/gui#248: Fix: For values of "Bytes transferred" and "Bytes/s" with 1000-based prefix names use 1000-based divisor instead of 1024-based (MarcoFalke) 63b1800 Merge bitcoin-core/gui#221: qt, refactor: rpcconsole translatable string fixes and improvements (MarcoFalke) 0d1faa2 fix: removed maximum width of transaction list on overview page (Konstantin Akimov) 458384a Merge bitcoin-core/gui#176: Fix TxViewDelegate layout (MarcoFalke) d670240 Revert "fix: remove stretching from Overview page when it's not needed" (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Backports of QT related improvements from bitcoin v22 ## What was done? See commits for list of backports. Changes related to improved behavior of columns while resizing for Transactions List and Recent Requests is dropped due to low performance and buggy behaviour. bitcoin-core/gui#205 and bitcoin-core/gui#229 are DNM due to incompatibility with our table view. It reverts also #5992 as better fix is found (see css changes). ## How Has This Been Tested? Run qt app, try to resize main view with overview page. ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: light ACK 2917c33 (CI failure is unrelated) PastaPastaPasta: light-ACK 2917c33 Tree-SHA512: b84c7e254562d86da30515d05572587edd1b451d988bbcfe16b8874f13d6b581910bed9008a7f8a408aae9181faa86703463fd508711e6e09b299be232ba3f48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Overview page has strange stretching on sides, which make balance moving left-right when window is scalled.
What was done?
Removed stretches for Overview Page from the sides, it makes window a little more balanced. This PR lets to do backport of bitcoin-core/gui#176 which improves behavior further more be increasing size of "transaction list" part of window.
How Has This Been Tested?
See screenshot. Resized window with/without patch, in "Discreet mode" off and on. Both looks not perfect but better than before.
Breaking Changes
N/A
Checklist: