Removed some unneeded code in deterministicmns #3731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pasta <pasta@dashboost.org>
Member
Author
|
So you think this should wait for 0.18? |
|
I can't say the exact version, it just feels too early to remove it (in less than 1y since the release). Let's get back to this idea mid next year or so. v0.17 might be good too if it isn't released by that time, otherwise these changes should go into v0.18+ I think. |
|
This pull request has conflicts, please rebase. |
|
@PastaPastaPasta @UdjinM6 This one can be closed since the cleanup already took place in #5113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pasta pasta@dashboost.org