refactor: streamline signature recovery process in CSigSharesManager

Removed the ProcessRecoveredSigUnlocked method and directly integrated its functionality into TryRecoverSig. This change simplifies the handling of recovered signatures for single-member quorums, ensuring proper lock management and enhancing code clarity.

Author: PastaPastaPasta

src/llmq/signing_shares.cpp

@@ -805,8 +805,6 @@ void CSigSharesManager::TryRecoverSig(const CQuorum& quorum, const uint256& id,
 
             singleMemberRecoveredSig = std::make_shared<CRecoveredSig>(quorum.params.type, quorum.qc->quorumHash, id, msgHash,
                                                       recoveredSig);
-            // Release lock before calling ProcessRecoveredSig to avoid double lock in HandleNewRecoveredSig
-            // ProcessRecoveredSig will synchronously call HandleNewRecoveredSig which requires the lock
         }
 
         sigSharesForRecovery.reserve((size_t) quorum.params.threshold);
@@ -825,7 +823,7 @@ void CSigSharesManager::TryRecoverSig(const CQuorum& quorum, const uint256& id,
 
     // Handle single-member quorum case after releasing the lock
     if (singleMemberRecoveredSig) {
-        ProcessRecoveredSigUnlocked(singleMemberRecoveredSig);
+        sigman.ProcessRecoveredSig(singleMemberRecoveredSig, m_peerman);
         return; // end of single-quorum processing
     }
 
@@ -857,12 +855,7 @@ void CSigSharesManager::TryRecoverSig(const CQuorum& quorum, const uint256& id,
         }
     }
 
-    ProcessRecoveredSigUnlocked(rs);
-}
-
-void CSigSharesManager::ProcessRecoveredSigUnlocked(const std::shared_ptr<const CRecoveredSig>& recoveredSig)
-{
-    sigman.ProcessRecoveredSig(recoveredSig, m_peerman);
+    sigman.ProcessRecoveredSig(rs, m_peerman);
 }
 
 CDeterministicMNCPtr CSigSharesManager::SelectMemberForRecovery(const CQuorum& quorum, const uint256 &id, int attempt)

src/llmq/signing_shares.h

@@ -477,9 +477,6 @@ class CSigSharesManager : public CRecoveredSigsListener
     void ProcessSigShare(const CSigShare& sigShare, const CQuorumCPtr& quorum) EXCLUSIVE_LOCKS_REQUIRED(!cs);
     void TryRecoverSig(const CQuorum& quorum, const uint256& id, const uint256& msgHash) EXCLUSIVE_LOCKS_REQUIRED(!cs);
 
-private:
-    void ProcessRecoveredSigUnlocked(const std::shared_ptr<const CRecoveredSig>& recoveredSig) LOCKS_EXCLUDED(cs);
-
     bool GetSessionInfoByRecvId(NodeId nodeId, uint32_t sessionId, CSigSharesNodeState::SessionInfo& retInfo)
         EXCLUSIVE_LOCKS_REQUIRED(!cs);
     static CSigShare RebuildSigShare(const CSigSharesNodeState::SessionInfo& session, const std::pair<uint16_t, CBLSLazySignature>& in);