Skip to content

Commit e596fa5

Browse files
knstthephez
authored andcommitted
Apply suggestions from code review
Co-authored-by: thephez <thephez@users.noreply.github.com>
1 parent beee5c1 commit e596fa5

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

doc/release-process.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Release Process
88
Before every minor and major release:
99

1010
* [ ] Update [bips.md](bips.md) to account for changes since the last release.
11-
* [ ] Update [dips.md](https://github.com/dashpay/dips/) to account for changes since the last release.
11+
* [ ] Update DIPs with any changes introduced by this release (see [this pull request](https://github.com/dashpay/dips/pull/142) for an example)
1212
* [ ] Update version in `configure.ac` (don't forget to set `CLIENT_VERSION_IS_RELEASE` to `true`) (don't forget to set `CLIENT_VERSION_RC` to `0`)
1313
* [ ] Write release notes (see below)
1414
* [ ] Update `src/chainparams.cpp` nMinimumChainWork with information from the getblockchaininfo rpc.
@@ -18,7 +18,7 @@ Before every minor and major release:
1818
- This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
1919
that causes rejection of blocks in the past history.
2020
* [ ] Ensure all TODOs are evaluated and resolved if needed
21-
* [ ] Verify insight works
21+
* [ ] Verify Insight works
2222
* [ ] Verify p2pool works (unmaintained; no responsible party)
2323
* [ ] Tag version and push (see below)
2424
* [ ] Validate that CI passes
@@ -168,7 +168,7 @@ popd
168168
cat "$VERSION"/*/all.SHA256SUMS.asc > SHA256SUMS.asc
169169
```
170170
* [ ] GPG sign each download / binary
171-
* [ ] Upload zips and installers, as well as SHA256SUMS.asc from last step, to github as github draft release.
171+
* [ ] Upload zips and installers, as well as SHA256SUMS.asc from last step, to GitHub as GitHub draft release.
172172
1. The contents of each `./dash/guix-build-${VERSION}/output/${HOST}/` directory, except for
173173
`*-debug*` files.
174174

@@ -190,10 +190,10 @@ cat "$VERSION"/*/all.SHA256SUMS.asc > SHA256SUMS.asc
190190
2. The `SHA256SUMS` file
191191

192192
3. The `SHA256SUMS.asc` combined signature file you just created
193-
* [ ] Validate SHA256SUMS.asc and all binaries attached to github draft release are correct
194-
* [ ] Notarize OS X binaries (we can't do this) (talk to @tikhop (pavel) about this
195-
* [ ] Release on github
196-
* [ ] Update website
193+
* [ ] Validate SHA256SUMS.asc and all binaries attached to GitHub draft release are correct
194+
* [ ] Notarize macOS binaries
195+
* [ ] Release on GitHub
196+
* [ ] Update the dash.org download links
197197
* [ ] Ensure that docker hub images are up to date
198198

199199
### Announce the release:
@@ -207,7 +207,7 @@ cat "$VERSION"/*/all.SHA256SUMS.asc > SHA256SUMS.asc
207207

208208
### After the release:
209209
- [ ] Submit patches to BTCPay to ensure they use latest / compatible version see https://github.com/dashpay/dash/issues/4211#issuecomment-966608207
210-
- [ ] Update docs (readme and RTD)
210+
- [ ] Update Core and User docs (docs.dash.org)
211211
- [ ] Test Docker build runs without error in Dashmate
212212
- [ ] Add new Release Process items to repo [Release Process](release-process.md) document
213213

0 commit comments

Comments
 (0)