fix: stop trying to sign pending txes when they are no longer non-locked

UdjinM6 · UdjinM6 · commit d8449aecf907 · 2024-08-05T10:28:05.000+03:00
diff --git a/src/llmq/instantsend.cpp b/src/llmq/instantsend.cpp
@@ -1202,6 +1202,8 @@ void CInstantSendManager::RemoveNonLockedTx(const uint256& txid, bool retryChild
             retryChildrenCount++;
         }
     }
+    // don't try to lock it anymore
+    WITH_LOCK(cs_pendingRetry, pendingRetryTxs.erase(txid));
 
     if (info.tx) {
         for (const auto& in : info.tx->vin) {

Original file line number	Diff line number	Diff line change
`@@ -1202,6 +1202,8 @@ void CInstantSendManager::RemoveNonLockedTx(const uint256& txid, bool retryChild`
`1202`	`1202`	`retryChildrenCount++;`
`1203`	`1203`	`}`
`1204`	`1204`	`}`
	`1205`	`+ // don't try to lock it anymore`
	`1206`	`+ WITH_LOCK(cs_pendingRetry, pendingRetryTxs.erase(txid));`
`1205`	`1207`
`1206`	`1208`	`if (info.tx) {`
`1207`	`1209`	`for (const auto& in : info.tx->vin) {`