Merge pull request #3105 from codablock/pr_backport_10854

UdjinM6 · web-flow · commit d6ca9a78ef76 · 2019-09-24T17:41:20.000+03:00
Backport bitcoin#10854: Avoid using sizes on non-fixed-width types to derive protocol constants
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3826,7 +3826,7 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend, CWalletT
                 vecTxDSInTmp.clear();
                 for (const auto& coin : setCoins) {
                     CTxIn txin = CTxIn(coin.outpoint,CScript(),
-                                              std::numeric_limits<unsigned int>::max()-1);
+                                              CTxIn::SEQUENCE_FINAL - 1);
                     vecTxDSInTmp.push_back(CTxDSIn(txin, coin.txout.scriptPubKey));
                     txNew.vin.push_back(txin);
                 }

Original file line number	Diff line number	Diff line change
`@@ -3826,7 +3826,7 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend, CWalletT`
`3826`	`3826`	`vecTxDSInTmp.clear();`
`3827`	`3827`	`for (const auto& coin : setCoins) {`
`3828`	`3828`	`CTxIn txin = CTxIn(coin.outpoint,CScript(),`
`3829`		`- std::numeric_limits<unsigned int>::max()-1);`
	`3829`	`+ CTxIn::SEQUENCE_FINAL - 1);`
`3830`	`3830`	`vecTxDSInTmp.push_back(CTxDSIn(txin, coin.txout.scriptPubKey));`
`3831`	`3831`	`txNew.vin.push_back(txin);`
`3832`	`3832`	`}`