Correctly use SIGN_HEIGHT_OFFSET when checking for out of bound height

codablock · codablock · commit ce6b7d131f29 · 2019-01-31T18:49:13.000+01:00
diff --git a/src/llmq/quorums_signing.cpp b/src/llmq/quorums_signing.cpp
@@ -562,7 +562,7 @@ CQuorumCPtr CSigningManager::SelectQuorumForSigning(Consensus::LLMQType llmqType
     uint256 startBlock;
     {
         LOCK(cs_main);
-        if (signHeight > chainActive.Height()) {
+        if (signHeight - SIGN_HEIGHT_OFFSET > chainActive.Height()) {
             return nullptr;
         }
         startBlock = chainActive[signHeight - SIGN_HEIGHT_OFFSET]->GetBlockHash();

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,7 @@ CQuorumCPtr CSigningManager::SelectQuorumForSigning(Consensus::LLMQType llmqType`
`562`	`562`	`uint256 startBlock;`
`563`	`563`	`{`
`564`	`564`	`LOCK(cs_main);`
`565`		`- if (signHeight > chainActive.Height()) {`
	`565`	`+ if (signHeight - SIGN_HEIGHT_OFFSET > chainActive.Height()) {`
`566`	`566`	`return nullptr;`
`567`	`567`	`}`
`568`	`568`	`startBlock = chainActive[signHeight - SIGN_HEIGHT_OFFSET]->GetBlockHash();`