evo: utilize NetInfoEntry::IsTriviallyValid() in ProTx trivial checks

Also, ProRegTx allows an empty netInfo, ProUpServTx does not, so we
should check that ProUpServTx::netInfo isn't empty.

Author: kwvg

src/evo/providertx.cpp

@@ -36,6 +36,11 @@ bool CProRegTx::IsTriviallyValid(bool is_basic_scheme_active, TxValidationState&
     if (!scriptPayout.IsPayToPublicKeyHash() && !scriptPayout.IsPayToScriptHash()) {
         return state.Invalid(TxValidationResult::TX_BAD_SPECIAL, "bad-protx-payee");
     }
+    for (const NetInfoEntry& entry : netInfo.GetEntries()) {
+        if (!entry.IsTriviallyValid()) {
+            return state.Invalid(TxValidationResult::TX_BAD_SPECIAL, "bad-protx-netinfo-bad");
+        }
+    }
 
     CTxDestination payoutDest;
     if (!ExtractDestination(scriptPayout, payoutDest)) {
@@ -105,6 +110,14 @@ bool CProUpServTx::IsTriviallyValid(bool is_basic_scheme_active, TxValidationSta
     if (nVersion < ProTxVersion::BasicBLS && nType == MnType::Evo) {
         return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-protx-evo-version");
     }
+    if (netInfo.IsEmpty()) {
+        return state.Invalid(TxValidationResult::TX_BAD_SPECIAL, "bad-protx-netinfo-empty");
+    }
+    for (const NetInfoEntry& entry : netInfo.GetEntries()) {
+        if (!entry.IsTriviallyValid()) {
+            return state.Invalid(TxValidationResult::TX_BAD_SPECIAL, "bad-protx-netinfo-bad");
+        }
+    }
 
     return true;
 }